Re: ext/mbstring dependencies
| From: | Hannes Magnússon | Date: | Mon, 06 Dec 2010 10:21:24 +0000 |
| Subject: | Re: ext/mbstring dependencies | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-50867@lists.php.net to get a copy of this message | ||
On Mon, Dec 6, 2010 at 09:31, Dmitry Stogov <dmitry@zend.com> wrote:
> Hi,
>
> The proposed patch completely removes ext/mbstring compile-time
> dependencies. As result the same php binaries may be used for Asian and
> European languages without performance degradation. ext/mbstring now may be
> compiled as a DSO. I'm going to commit the patch on Wednesday.
> Any comments are welcome.
>
Random scrolling through the patch:
Index: ext/mbstring/mbstring.c
+// to = php_mb_convert_encoding(from, from_len, encoding_to,
encoding_from, to_length);
+// return to ? 0 : -1;
and WS
+ !memcmp("none", name, sizeof("none") - 1)))) {
-Hannes