Re: embedded libmagic (from file)
| From: | Raphael Geissert | Date: | Tue, 22 Mar 2011 05:06:28 +0000 |
| Subject: | Re: embedded libmagic (from file) | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-51738@lists.php.net to get a copy of this message | ||
Scott MacVicar wrote:
> I have a diff sitting that I did yesterday that upgrades us to the
> latest libmagic, it supports the new magic file format and updates
> that bundle. But that's all.
>
> I'm also against allowing the non-php version. Yes it's a fork but
> unfortunately it's for the best.
Last time I checked there were some general bug fixes (e.g. fixing type
casting) that were not in upstream's version. Were they forwarded for 5.05?
(I haven't personally checked)
It's easy to understand the wish of hacking libmagic to provide some more
features, but it would be great to keep the divergence to the strict
minimum.
Cheers,
--
Raphael Geissert