Re: patch review
| From: | Peter Beverloo | Date: | Sun, 03 Apr 2011 11:30:06 +0000 |
| Subject: | Re: patch review | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-51803@lists.php.net to get a copy of this message | ||
2011/4/3 Tomas Brastavičius <tbrasta@gmail.com>:
> Hi,
>
> can somebody review the following patch:
> http://bugs.php.net/bug.php?id=54369
>
> I am willing the bug is fixed in the next PHP release and ready to do a
> job if something is wrong with the patch.
>
> Thank you
>
> Regards,
> Tomas
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
The parsing change you are proposing is invalid per RFC 1738. The
destination (hostname and port) and the url-path are to be divided by
a slash, whereas the query string and the fragment are part of the
latter.
See sections 3.3 and 5 of the RFC[1] for more information. Web
browsers and other user-facing software may accept this, but will
immediately update the displayed URL to a valid variant by inserting
the slash.
Regards,
Peter Beverloo
[1] http://tools.ietf.org/html/rfc1738.html