Re: Optional $limit argument for debug_backtrace()
| From: | Patrick ALLAERT | Date: | Fri, 08 Apr 2011 20:02:49 +0000 |
| Subject: | Re: Optional $limit argument for debug_backtrace() | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-51847@lists.php.net to get a copy of this message | ||
2011/4/8 Sebastian Bergmann <sebastian@php.net>:
> Am 04.04.2011 17:22, schrieb Sebastian Bergmann:
>> Any thoughts?
>
> Are there any objections to applying the latest version of the patch [1]
> to trunk? I still think that debug_backtrace and debug_print_backtrace
> are in need of refactoring but that should be kept separate, I think.
Not that this is a true blocker, but as said previously, and
considering the very few changes it introduces
(https://gist.github.com/910580), I'm not really in favor to introduce
it only in debug_bactrack() and not in debug_print_backtrace().
Both should be refactored, true, but I don't see the point to make them diverge.
I would even say that there is more benefit in terms of maintenance to
make them common now than introducing new feature to them.
Regards,
Patrick