Re: Need karma for committing test patches

> A few remarks: > > * Isn't this supposed to be fixed? Was there something that triggered a > regression? As far as I can see Jani checked only case when already closed file descriptor was passed to curl_setopt. Here's the check is performed in curl_exec, i.e. in curl_setopt file descriptor was valid and at the moment of call curl_setopt it's closed/invalid. > * If this strategy is used (checking whether the resource associated with > the stored zval is valid), how about curl_multi_exec? The logic is simple - if resource is ok, then go with it, else it's changed to default stderr. Did not tested it on curl_multi_exec(), just took the failed phpt file and got it working :) > * I think a better strategy would be to just dup the file descriptor gotten > after the cast in curl_setopt, store it (instead of storing the zval) and > close it on curl handle destruction. This way we wouldn't have to worry > about zval refcounts or whether the file descriptor obtained is still valid. > Could you see if this other strategy works? (otherwise I can do it later > this week) Yes, I like your strategy, will try to do it. Also I would be happy if somebody could answer my questions because "all documentation is written in C" is not so easy to understand :) > -- > Gustavo Lopes > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > -- Regards, Shein Alexey