[Patch] GeoIP Tests
| From: | Mike Willbanks | Date: | Mon, 06 Jun 2011 14:37:09 +0000 |
| Subject: | [Patch] GeoIP Tests | ||
| Groups: | php.internals | ||
| Request: | Send a blank email to internals+get-53029@lists.php.net to get a copy of this message | ||
I've gone through the GeoIP extension and ensured all of the tests now pass.
Bug Report: http://pecl.php.net/bugs/bug.php?id=22749
Patch File: http://blog.digitalstruct.com/patches/geoip-svn-tests.patch.txt
Also, it looks like the GeoIP extension is based on an extremely old
version, I am going to start looking to update this to get all of the new
constants that should exist into the extension.
A slight amount of behavior changed and should have been noted previously
for the test as "CA" is no longer a valid country code w/o a region in the
timeZone.c area of the GeoIP C API.
Someone with karma want to review and apply the patch for the tests?
Regards,
Mike