Re: [PATCH] openssl_pkcs7_encrypt to/from variable or file

Hi ! It's a problem for sure... Wez ? what do you think about that ? At 17:33 06/11/2003, Richard Antony Burton wrote:

Eric, Appologies, I should have been more careful to check I actually knew what I was talking about before I opened my mouth ;-) Didn't realise the existing private key version came in two separate functions like this. As I said, I'm a big fan of consistency, but I guess we have two precedents here - so either is good? I have to follow the other method for my patch, since there are two parameters to the function which could be either a variable or file, otherwise we would need four versions of the function to cover all combinations! Richard. ----- Original Message ----- From: "Eric COLINET" <e.colinet@laposte.net> To: "Richard Burton" <richardaburton@hotmail.com>; <internals@lists.php.net> Sent: Thursday, November 06, 2003 4:19 PM Subject: Re: [PHP-DEV] [PATCH] openssl_pkcs7_encrypt to/from variable or file Hi ! Richard, I understand very well the benefit of using only one function to do the same work, but they are already 2 function that does the same for private keys and for consistency i think i had to submit 2 function to do the same job for public keys. Of course the best way is to have only too function to do the job (one for public and one for private keys) but i just can't decide myself to break compatibility. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php