Re: [RFC] 5.4 features for vote (long)
| From: | Derick Rethans | Date: | Mon, 20 Jun 2011 15:50:30 +0000 |
| Subject: | Re: [RFC] 5.4 features for vote (long) | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-53420@lists.php.net to get a copy of this message | ||
On Mon, 20 Jun 2011, Felipe Pena wrote:
> 2011/6/20 Etienne Kneuss <colder@php.net>
> >
> > I'd love to see the proposal from Felipe about the improved parse
> > errors in that list. I believe that the patch was ready or almost
> > ready? I can't find the RFC though, but maybe the RFC never existed...
> >
>
> https://wiki.php.net/rfc/improved-parser-error-message
I think this is good and helpful.
I've two suggestions though:
- Add the token name in parenthesis at the end of the string
- Add '' around the token strings
Examples:
Parse error: syntax error, unexpected '<<=' (T_SL_EQUAL) in Command line code on
line 1
Parse error: syntax error, unexpected '::' (T_PAAMAYIM_NEKUDOTAYIM) in Command line code
on line 1
Parse error: syntax error, unexpected 'quoted-string' (T_CONSTANT_ENCAPSED_STRING),
expecting identifier or '(' in Command line code on line 1
And we need to make sure to check for escaped < and > in HTML error
messages :)
cheers,
Derick