Re: Small PHPAPI addition

2011/6/24 Derick Rethans <derick@php.net>: > On Fri, 24 Jun 2011, Johannes Schlüter wrote: > >> On Thu, 2011-06-23 at 21:47 +0100, Derick Rethans wrote: >> > >> > In order to fix Xdebug bug #587 >> > (http://bugs.xdebug.org/view.php?id=587) I need to have access to >> > module_initialized which is currently a static in main/main.c. I've >> > added a simple function to retrieve that and would like to commit >> > that to 5.3/5.4 and trunk. Comments? The patch is attached. >> >> I know the variable uses singular, but maybe >> php_get_modules_initialized() is clearer? > > But afaik, it means PHP as "module", so plural makes little sense to me? It is more about the SAPI than SAPI only available as module. I would add sapi in the function as well to avoid any confusion. php_sapi_get_module_initialized. Cheers, -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org