Re: [PATCH] getimagesize - return named keys for width, height, type and attributes
| From: | Paul Dixon | Date: | Mon, 11 Jul 2011 21:33:31 +0000 |
| Subject: | Re: [PATCH] getimagesize - return named keys for width, height, type and attributes | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-53894@lists.php.net to get a copy of this message | ||
On 08/07/11 17:28, Richard Quadling wrote:
On 8 July 2011 17:21, DIXON P.<paul.dixon@durham.ac.uk> wrote:respectively, and I can do that if people think that's best. However personally long term, I would aim to remove the position index entries completely. PaulThanks Richard, Renamed and attached. -----Original Message----- From: Richard Quadling [mailto:rquadling@gmail.com] Sent: 08 July 2011 17:13 To: DIXON P. Cc: internals@lists.php.net Subject: Re: [PHP-DEV] [PATCH] getimagesize - return named keys for width, height, type and attributes On 8 July 2011 17:10, DIXON P.<paul.dixon@durham.ac.uk> wrote:For consistency, should bits and mime become 4 and 5? This would work in the same way as using named capturing in a regex, where you get both the position index and the name in the result array and I think various db_fetch_as_array type functions also. It would be trivial to add 4, 5 and 6 for mime, channels and bitsHi, I've attached a patch ...Rename as .txt to get through the mailing list s/w.