Re: Magic quotes removal previous patch

+1 to E_CORE. -- Gwynne On Thu, Jul 21, 2011 at 06:28, Pierrick Charron <pierrick@webstart.fr> wrote: > I'm also ok with E_CORE. > > Pierrick > > On 21 July 2011 05:19, Pierre Joye <pierre.php@gmail.com> wrote: >> hi Pierrick! >> >> Thanks for the updated patch :) >> >> Now the only question remaining is which level warning we should use >> for the setter. I'm happy with E_CORE. Objections? >> >> On Thu, Jul 21, 2011 at 2:18 AM, Pierrick Charron <pierrick@webstart.fr> wrote: >>> I tried to send the patch as a .txt file but it seems my mail was not >>> send to internals since i don't see it on news.php.net. >>> >>> Anyway you'll find patch (code + tests) here : >>> - http://www.adoy.net/php/remove-magic-quotes.txt >>> - ¯—ƒ¢V: >>> ú!Ì;Û—http://www.adoy.net/php/remove-magic-quotes-tests.txt >>> >>> Pierrick >>> >>> On 20 July 2011 15:44, Pierre Joye <pierre.php@gmail.com> wrote: >>>> >>>> hi, >>>> >>>> Please find as attachment the previous patch to remove the magic quotes. >>>> >>>> The log I was using back then was (5 years ago already, mq resists :): >>>> >>>>  Log: >>>>  - remove magic_quotes_gpc, magic_quotes_runtime, magic_quotes_sybase >>>>  (calling ini_set('magic_....') returns 0|false >>>>  - get_magic_quotes_gpc, get_magic_quotes_runtime are kept but always >>>> return false >>>>  - set_magic_quotes_runtime raises an E_CORE_ERROR >>>> >>>> Cheers, >>>> -- >>>> Pierre >>>> >>>> @pierrejoye | http://blog.thepimp.net | >>>> http://www.libgd.org >>>> >>>> -- >>>> PHP Internals - PHP Runtime Development Mailing List >>>> To unsubscribe, visit: http://www.php.net/unsub.php >>> >> >> >> >> -- >> Pierre >> >> @pierrejoye | http://blog.thepimp.net | >> http://www.libgd.org >> > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > >