Re: new gcov.php.net machine is up
| From: | Hannes Magnusson | Date: | Sat, 23 Jul 2011 23:21:59 +0000 |
| Subject: | Re: new gcov.php.net machine is up | ||
| References: | 1 2 3 4 5 6 7 | Groups: | php.internals php.qa |
| Request: | Send a blank email to internals+get-54178@lists.php.net to get a copy of this message | ||
On Sun, Jul 24, 2011 at 01:07, Gwynne Raskind <gwynne@darkrainfall.org> wrote:
> Here's my question - if I made some smaller commits here and there to
> fix warnings in core, would that be accepted? I don't have time to do
> sweeping changes, but fixing one file today, a couple the next day,
> etc., is within my abilities (including making sure no regressions are
> introduced, of course).
Why on earth would anyone complain about such commit from an
already-trusted-person-with-karma?
If you start flooding the commit list with one-liners, people will
probably complain.
But if you are willing to do the extensive work needed to fix several
warnings per commit..
I personally wouldn't commit such patch from 3rd party.
Reverting such commit from a person I trust however wouldn't come to mind.
Cursory review would be all *I* would do.
Can't speak for anyone else...
Fixing these sort of warnings in existing stable releases however IMO
causes more risk then necessary.
-Hannes