Re: [PATCH] crypt_blowfish 1.2
| From: | Pierre Joye | Date: | Sun, 31 Jul 2011 20:50:26 +0000 |
| Subject: | Re: [PATCH] crypt_blowfish 1.2 | ||
| References: | 1 2 3 4 5 6 7 8 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-54266@lists.php.net to get a copy of this message | ||
applied :)
Thanks again!
On Sun, Jul 31, 2011 at 10:05 PM, Solar Designer <solar@openwall.com> wrote:
> On Sun, Jul 31, 2011 at 08:56:30PM +0200, Pierre Joye wrote:
>> It looks like your original patch did not change anything in crypt.c
>
> That's correct. I overlooked the need to modify crypt.c initially.
> I only got to that when adding the extra tests, at which time I also
> found the incorrect check in 5.4's crypt.c from the upgrade to
> crypt_blowfish 1.1 a month ago.
>
>> I see now the other patch posted on the 20th, I missed it and it
>> indeed fixes the checks in crypt.c :) I will apply it shortly!
>
> Yes, please. Thanks!
>
> Alexander
>
--
Pierre
@pierrejoye | http://blog.thepimp.net | http://www.libgd.org