Re: Build broken: ext/xsl/xsltprocessor.c

Thanks for the fix, but it is still failing in xsltprocessor.c, as far as I can tell: /tmp/buildd/php5-5.3.99+5.4.0/ext/xsl/xsltprocessor.c: In function 'xsl_ext_function_php': /tmp/buildd/php5-5.3.99+5.4.0/ext/xsl/xsltprocessor.c:242: warning: pointer targets in initialization differ in signedness /tmp/buildd/php5-5.3.99+5.4.0/ext/xsl/xsltprocessor.c:252: warning: pointer targets in assignment differ in signedness /tmp/buildd/php5-5.3.99+5.4.0/ext/xsl/xsltprocessor.c:272: warning: pointer targets in passing argument 1 of 'xmlStrdup' differ in signedness /usr/include/libxml2/libxml/xmlstring.h:41: note: expected 'const xmlChar *' but argument is of type 'char *' /tmp/buildd/php5-5.3.99+5.4.0/ext/xsl/xsltprocessor.c:275: warning: pointer targets in passing argument 3 of 'xmlNewDocNode' differ in signedness /usr/include/libxml2/libxml/tree.h:782: note: expected 'const xmlChar *' but argument is of type 'char *' /tmp/buildd/php5-5.3.99+5.4.0/ext/xsl/xsltprocessor.c:277: warning: pointer targets in passing argument 3 of 'xmlNewDocNode' differ in signedness /usr/include/libxml2/libxml/tree.h:782: note: expected 'const xmlChar *' but argument is of type 'char *' /tmp/buildd/php5-5.3.99+5.4.0/ext/xsl/xsltprocessor.c:283: warning: passing argument 4 of 'php_dom_create_object' from incompatible pointer type /tmp/buildd/php5-5.3.99+5.4.0/ext/xsl/../dom/xml_common.h:57: note: expected 'struct dom_object *' but argument is of type 'struct zval *' /tmp/buildd/php5-5.3.99+5.4.0/ext/xsl/xsltprocessor.c:283: error: too many arguments to function 'php_dom_create_object' Full log: https://drupaltesting.org/jenkins/job/php5.4-build/237/consoleFull Damien On Mon, Aug 8, 2011 at 6:06 PM, Ilia Alshanetsky <ilia@prohost.org> wrote: > Thanks, I've just applied a fix for this. > > On Mon, Aug 8, 2011 at 10:45 AM, Damien Tournoud <damz@damz.org> wrote: >> Just FYI, this commit broke the build: >> >> >>  http://svn.php.net/viewvc?view=revision&revision=314515 >> >> One occurrence as been missed in: >> >>  ext/xsl/xsltprocessor.c:                        DOM_RET_OBJ(rv, >> (xmlNodePtr) newdocp, &ret, NULL); >> >> Reference: >> https://drupaltesting.org/jenkins/job/php5.4-build/235/ >> >> Damien >> >> -- >> PHP Internals - PHP Runtime Development Mailing List >> To unsubscribe, visit: http://www.php.net/unsub.php >> >> >