Re: Coverity Scan
| From: | Joey Smith | Date: | Tue, 09 Aug 2011 07:45:19 +0000 |
| Subject: | Re: Coverity Scan | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-54488@lists.php.net to get a copy of this message | ||
On Tue, Aug 09, 2011 at 12:19:53AM -0700, Rasmus Lerdorf wrote:
> On 08/08/2011 11:45 PM, Joey Smith wrote
> > A lot of the 'STACK_USE' ones seem to be false positives; it's reporting
> > when the stack "exceeds the maximum single use of 1024 bytes" - that 1024
> > is a Coverity-configurable value which defaults to 1024.
>
> Yup, we can simply mark those as intentional/ignore although it wouldn't
> be a bad idea to have a quick look at each one to see if we really need
> to chew up 1k of stack on each of those occasions. People using PHP in
> embedded systems would appreciate that, I bet.
>
> -Rasmus
Quite a few of the ones I looked at were reporting it due to MAXPATHLEN,
which I imagine we probably want to leave untouched - I'll just mark those
as intentional/ignore.