Re: types conversion mistakes in cli's server
| From: | Pierre Joye | Date: | Thu, 18 Aug 2011 09:16:24 +0000 |
| Subject: | Re: types conversion mistakes in cli's server | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-54674@lists.php.net to get a copy of this message | ||
done in r315128
On Wed, Aug 17, 2011 at 5:19 PM, Pierre Joye <pierre.php@gmail.com> wrote:
> Hi
>
> There are many loosely conversions in the CLI web server. Mostly from
> (u)int64 to size_t (on 32bit platforms) or in64t to char, or the other
> way 'round.
>
> What was the goal to support 64bit data range for content length (or
> read data) in 32 bit environments? If LFS support was the goal, it
> could be possible to make it server large files but the way it is now
> won't work.
>
> Any objection if I change it to use exclusively size_t to avoid any
> possible issues?
>
> Cheers,
> --
> Pierre
>
> @pierrejoye | http://blog.thepimp.net |
> http://www.libgd.org
>
--
Pierre
@pierrejoye | http://blog.thepimp.net | http://www.libgd.org