Re: Use system crypt() when possible
| From: | Pierre Joye | Date: | Tue, 23 Aug 2011 07:56:35 +0000 |
| Subject: | Re: Use system crypt() when possible | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-54818@lists.php.net to get a copy of this message | ||
On Tue, Aug 23, 2011 at 9:16 AM, Ondřej Surý <ondrej@sury.org> wrote:
> Cool, that was the response I was hoping for :). I can do some basic
> testing myself and I will speak with other maintainers and porters for
> help on the esoteric systems (Windows, VMS, etc... :))
Windows will always use the builting versions, so will VMS I think,
have to check with Klaus, or if you can do it :)
I was more thinking about some non compatible BSD versions and
similar, which create non portable hashes or implementation (php side
that is).
>> Then main problem here is about systems doing weird or non
>> standard things. Debian does or did that for a couple of things,
>
> I understand your reasoning (doesn't mean I agree :-) and I propose
> to add tests for hash results to config.m4, so if there is a weird thing
> in the system crypt() it will not be used.
>
>> I prefer true portability.
>
> On the other hand, one might argue that using the system crypt
> allows on-system compatibility, so you might use the saved passwords
> with other languages and system tools.
>
> So I will probably go the way I have outlined in the bug - the user
> will have the choice between system,internal,mixed with mixed
> as the default option.
Right, that sounds good but it will be a pain to maintain :)
Cheers,
--
Pierre
@pierrejoye | http://blog.thepimp.net | http://www.libgd.org