Re: Re: [ANNOUNCEMENT] DB_DataObject-1.9.6 (stable) Released.

On 29 August 2011 08:21, Ferenc Kovacs <tyra3l@gmail.com> wrote: > On Mon, Aug 29, 2011 at 7:20 AM, PEAR Announce <pear-dev@lists.php.net> wrote: >> The new PEAR package DB_DataObject-1.9.6 (stable) has been released at >> http://pear.php.net/. >> >> Release notes >> ------------- >> Small fix release. >> >>  #18749 - Fix is_a() for 5.3.7+ due to php-core stupidity >>  #18602 - optimize fetch - thanks to shadesofgraylin >>  #18605 - optimize sprintf in toArray() >>  #18446 - use table() method rather than accessing static global. >>  #----- - toArray support for only returning returned columns use "0" as the >> second parameter >>  #----- - allow tableless dataobject connect() call to work >>  #----- - disable overload using DB_DATAOBJECT_NO_OVERLOAD on PHP5 - Im supprised no one >> ever noticed this - overload is EVIL ;) >>  #----- - Add autoJoin method, which will build a full join with all related tables. >>  #16867 - fix doc comments - change to public methods for the ones that are supposed to be >> overridden >>  #17637 - fix detection of non-existant links files resulting in defaulting to autolinks >> >> Package Info >> ------------ >> DataObject performs 2 tasks: >>  1. Builds SQL statements based on the objects vars and the builder methods. >>  2. acts as a datastore for a table row. >>  The core class is designed to be extended for each of your tables so that you put the >>  data logic inside the data classes. >>  included is a Generator to make your configuration files and your base classes. >> >> Related Links >> ------------- >> Package home: http://pear.php.net/package/DB_DataObject >>   Changelog: >> http://pear.php.net/package/DB_DataObject/download/1.9.6 >>    Download: >> http://download.pear.php.net/package/DB_DataObject-1.9.6.tgz >> >> Authors >> ------- >> Alan Knowles <alan@akbkhome.com> (lead) >> >> >> -- >> PEAR General Mailing List (http://pear.php.net/) >> To unsubscribe, visit: http://www.php.net/unsub.php >> >> > > > Hi Alan, > > I think it really bad attitude to call the php-core (either the > project or the team) as stupid, and as PEAR is an official php project > I think that the recently announced Code of conduct applies here also: > http://lwn.net/Articles/452278/ > > It is really unfortunate that this change was introduced in the 5.3 > branch, but it is also unfortunate that nobody really noticed this > change and the implications before we shipped the stable release. > > here is a short summary about what happened: > > http://www.mail-archive.com/internals@lists.php.net/msg52981.html > > The change itself is/was supported by the majority of the core devs Please, don't speak for the majority of the core devs when that's really not the case. > (the only disagreement was about having this in the 5.3 branch in the > first place and should we keep it or revert back to the old behavior > with the next stable release), as the previous behavior was > undocumented (that you can pass mixed as the first argument to is_a()) > and inconsistent. > > Fortunately fixing your code is easy, just make sure that you pass a > valid object to is_a() or usage of the instanceof operator. > > I think that instead of finger-pointing we should work on how to > prevent similar changes in the future, so maybe the php and the pear > qa groups should work more closely, and test that pear is working with > the RCs. > > -- > Ferenc Kovács > @Tyr43l - http://tyrael.hu > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > >