Re: Re: drop bison 1.x?
| From: | Hannes Magnusson | Date: | Thu, 01 Sep 2011 18:44:35 +0000 |
| Subject: | Re: Re: drop bison 1.x? | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-55068@lists.php.net to get a copy of this message | ||
Thats not something you do in a bugfix release.
Is different error messages really the only reason you want to drop 1.x?
Seems like a bad reason.
Why are we testing error messages from a 3rd party software anyway?
-Hannes
On Thu, Sep 1, 2011 at 19:14, Pierre Joye <pierre.php@gmail.com> wrote:
> I will simply drop 1.4 support by Monday if there is no opposition.
>
> Cheers,
>
> On Thu, Sep 1, 2011 at 11:22 AM, Pierre Joye <pierre.php@gmail.com> wrote:
>> Hi,
>>
>> It would help a lot to test the parser if we drop bison 1.x support.
>> It won't change anything in the parser rules or in the code base but
>> only the way we test it. Bison version 1.x has different messages than
>> 2.x (formats and contents). It causes some tests to fail because of
>> these different messages.
>>
>> I wonder if we could simply stop to support bison 1.x in 5.3 and later
>> or at least in 5.4+. But if we do it in 5.4+ only it will be harder to
>> maintain both tests synced and compared the results between the two
>> branches (eventual BC breaks or similar breakages).
>>
>> Comments?
>>
>> Cheers,
>> --
>> Pierre
>>
>> @pierrejoye | http://blog.thepimp.net |
>> http://www.libgd.org
>>
>
>
>
> --
> Pierre
>
> @pierrejoye | http://blog.thepimp.net |
> http://www.libgd.org
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>