Re: Re: svn: /php/php-src/ branches/PHP_5_4/Zend/zend_execute_API.c trunk/Zend/zend_execute_API.c

On Wed, Sep 7, 2011 at 11:20 PM, Rasmus Lerdorf <rasmus@lerdorf.com> wrote: > On 09/07/2011 02:12 PM, Stas Malyshev wrote: >> But it doesn't send SIGPROF by itself. Looks like Darwin got screwed up >> itimer implementation at least up to kernel 10.8.0, Mac OS X 10.6.8. >> Didn't try it on Lion, maybe the have updated/fixed it. > > Right, so we need to decide what to do about that. Timing out a tight > loop with absolutely nothing inside isn't a typical user scenario, so > for this particular case we could probably just make the for loop do > something trivial. But we should also note this somewhere and maybe have > a Darwin-only XFAIL test case. Reading this makes me think about a new feature we were talking about on IRC earlier this week. What do you think to have platform/settings EXPECT*, which could be define via either skipif, a new section or automatically (EXPECTF-DARWIN, EXPECTF-WINDOWS, etc.)? It could help to have many tests for the same code but with only various msgs or very small changes. Cheers, -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org