[PATCH]#55651
| From: | Avi Brender | Date: | Sun, 11 Sep 2011 04:55:45 +0000 |
| Subject: | [PATCH]#55651 | ||
| Groups: | php.internals | ||
| Request: | Send a blank email to internals+get-55358@lists.php.net to get a copy of this message | ||
Hi Laruence,
Sure thing - I was just using the above code that verified the AUTOSEEK option as a template. I've changed it to use convert_to_boolean_ex as per your suggestion :)
Thanks!
Avi Brender
Elite Hosts, Inc
www.elitehosts.com
On 09/10/2011 11:59 PM, Laruence wrote:
Attachment: [text/x-patch] ftp_usepasvaddress.patch
Hi:after a quick look, I have one suggestion, if the (Z_TYPE_P(z_value) != IS_BOOL), you should callconvert_to_boolean_ex to convert it to a booleanotherwise, people can not use a interge 1 as a true flag.thanks2011/9/11 Avi Brender<abrender@elitehosts.com>:Hi, I've submitted bug #55651 along with a patch to implement a fix (also attached) for the passive FTP mode issue. I was hoping that someone could review the bug report and consider the patch for inclusion in future PHP releases. Thanks so much! Avi Brender Elite Hosts, Inc www.elitehosts.com -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Attachment: [text/x-patch] ftp_usepasvaddress.patch