Re: A couple of missing directories if configure.js is forgotten.
| From: | Richard Quadling | Date: | Fri, 16 Sep 2011 12:30:21 +0000 |
| Subject: | Re: A couple of missing directories if configure.js is forgotten. | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-55474@lists.php.net to get a copy of this message | ||
2011/9/15 Ángel González <keisial@gmail.com>:
> Richard Quadling wrote:
>>
>> Hi.
>>
>> Sometimes I remove Release prior to nmake to make sure everything builds
>> clean.
>>
>> 2 directories fail to get build
>>
>> Release\win32
>> Release\devel
>>
>> The attached patch fixes that.
>>
>> - @for %D in ($(BUILD_DIRS_SUB)) do @if not exist %D @mkdir %D> NUL
>> + @for %D in ($(BUILD_DIRS_SUB) devel win32) do @if not exist %D
>> @mkdir %D> NUL
>>
>>
>>
>> Richard.
>
> Shouldn't you add them to BUILD_DIRS_SUB instead?
>
>
Yep! See bug https://bugs.php.net/bug.php?id=55710 with latest
patch.
It was an edge case for the win32 directory caused by having
pecl/win32service configured for building. Any extension with win32 in
it would have caused the issue.
--
Richard Quadling
Twitter : EE : Zend : PHPDoc
@RQuadling : e-e.com/M_248814.html : bit.ly/9O8vFY : bit.ly/lFnVea