Re: svn: /php/php-src/ branches/PHP_5_3/ext/calendar/tests/easter_date.phpt branches/PHP_5_4/ext/calendar/tests/easter_date.phpt
trunk/ext/calendar/tests/easter_date.phpt

Derick, could you look into this? I think that the easter_days should take the date.timezone account when calculating a timestamp On Thu, Sep 22, 2011 at 10:59 PM, Ferenc Kovacs <tyrael@php.net> wrote: > tyrael                                   Thu, 22 Sep 2011 20:59:10 +0000 > > Revision: > http://svn.php.net/viewvc?view=revision&revision=317164 > > Log: > it seems that easter_date doesn't use the date.timezone but the TZ environment variable, > so it passing the return value of easter_date() to date() which uses the date.timezone will create > wrong result. > > Changed paths: >    U   php/php-src/branches/PHP_5_3/ext/calendar/tests/easter_date.phpt >    U   php/php-src/branches/PHP_5_4/ext/calendar/tests/easter_date.phpt >    U   php/php-src/trunk/ext/calendar/tests/easter_date.phpt > > Modified: php/php-src/branches/PHP_5_3/ext/calendar/tests/easter_date.phpt > =================================================================== > --- php/php-src/branches/PHP_5_3/ext/calendar/tests/easter_date.phpt    2011-09-22 17:53:20 > UTC (rev 317163) > +++ php/php-src/branches/PHP_5_3/ext/calendar/tests/easter_date.phpt    2011-09-22 20:59:10 > UTC (rev 317164) > @@ -6,6 +6,7 @@ >  <?php include 'skipif.inc'; ?> >  --FILE-- >  <?php > +putenv('TZ=UTC'); >  echo date("Y-m-d", easter_date(2000))."\n"; >  echo date("Y-m-d", easter_date(2001))."\n"; >  echo date("Y-m-d", easter_date(2002))."\n"; > > Modified: php/php-src/branches/PHP_5_4/ext/calendar/tests/easter_date.phpt > =================================================================== > --- php/php-src/branches/PHP_5_4/ext/calendar/tests/easter_date.phpt    2011-09-22 17:53:20 > UTC (rev 317163) > +++ php/php-src/branches/PHP_5_4/ext/calendar/tests/easter_date.phpt    2011-09-22 20:59:10 > UTC (rev 317164) > @@ -6,6 +6,7 @@ >  <?php include 'skipif.inc'; ?> >  --FILE-- >  <?php > +putenv('TZ=UTC'); >  echo date("Y-m-d", easter_date(2000))."\n"; >  echo date("Y-m-d", easter_date(2001))."\n"; >  echo date("Y-m-d", easter_date(2002))."\n"; > > Modified: php/php-src/trunk/ext/calendar/tests/easter_date.phpt > =================================================================== > --- php/php-src/trunk/ext/calendar/tests/easter_date.phpt       2011-09-22 17:53:20 UTC (rev > 317163) > +++ php/php-src/trunk/ext/calendar/tests/easter_date.phpt       2011-09-22 20:59:10 UTC (rev > 317164) > @@ -6,6 +6,7 @@ >  <?php include 'skipif.inc'; ?> >  --FILE-- >  <?php > +putenv('TZ=UTC'); >  echo date("Y-m-d", easter_date(2000))."\n"; >  echo date("Y-m-d", easter_date(2001))."\n"; >  echo date("Y-m-d", easter_date(2002))."\n"; > > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php >