Re: [PATCH] Autoguessing TEST_PHP_EXECUTABLE if none is provided in run-tests.php

2011/9/8 Alexey Shein <confik@gmail.com>: > Hello! > I've made some improvements to run-tests.php: > 1) Autoguessing TEST_PHP_EXECUTABLE and TEST_PHP_CGI_EXECUTABLE if > they're not provided, i.e. assume they have value 'auto'. You can > still pass your own value as usual. > 2) Added option -n (use no php.ini) to the shebang line > (#!/usr/bin/php -n) so it would run more reliably on some hosts. My > Ubuntu setup did not have E letter in variables_order (i.e. > variables_order=GPCS) so $_ENV array was empty and some tests were > skipped when they could be run. > 3) Some better error handling of wrong paths > > So now you can run run-tests.php with just > $ ./run-tests.php ext > instead of > $ TEST_PHP_EXECUTABLE=auto php -n run-tests.php ext > > You can also run run-tests.php from sub-dir, it will correctly guess > 'auto' as well: > $ cd ext/ > $ ../run-tests.php zlib > > Please, review this patch and, if there's no objections, I will > prepare 5.4 and 5.3 versions too. > > -- > Regards, > Shein Alexey > +1 I have no tried the patch, but the additions sounds good to me. -- Regards, Felipe Pena