Re: Merge fix for #54918 (r311748) to 5.4?
| From: | Stas Malyshev | Date: | Mon, 26 Sep 2011 17:08:37 +0000 |
| Subject: | Re: Merge fix for #54918 (r311748) to 5.4? | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-55629@lists.php.net to get a copy of this message | ||
Hi!
On 9/26/11 1:42 AM, Pierre Joye wrote:
It may be good to merge http://svn.php.net/viewvc?view=revision&revision=311748 to 5.4 too. This commit is about issues similar to the one describe in #54918. Any reason not to do it before next beta/rc?I'm not sure I understand this patch completely. I understand that if one of the MINITs fails, this patch just continues. But we have tons of code that assumes all basic MINITs worked - we always use variables initialized in these MINITs without checking, etc. So does it really make sense to continue if one of basic MINITs fail? On regular module loading, MINIT failure is E_CORE_ERROR, why not here? -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227