Re: [PATCH] Fix for bug #55754
| From: | Johannes Schlüter | Date: | Thu, 06 Oct 2011 16:15:55 +0000 |
| Subject: | Re: [PATCH] Fix for bug #55754 | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-55710@lists.php.net to get a copy of this message | ||
On Thu, 2011-10-06 at 17:59 +0200, Daniel K. wrote:
> On 10/06/2011 05:55 PM, Stas Malyshev wrote:
> > On 10/6/11 5:31 PM, Daniel K. wrote:
> >> A patch was appended, discussed, and improved, and I have uploaded a
> >> test-case, as well as a minimal patch that fixes the problem (attached)
> >> to the original bug-report.
> >>
> >> https://bugs.php.net/bug.php?id=55754
> >>
> >> The patch still applies to trunk, and I think it should be applied to
> >> the 5.3 and 5.4 branches as well.
> >
> > As far as I can see, the patch looks good, so it can be applied to 5.4
> > and trunk. If I don't hear any objections and nobody beats me to it,
> > I'll do it in a couple of days (a bit busy now).
>
> OK, thanks.
>
> But what about 5.3? there is no ABI issue with this, just a spurious
> warning that goes away.
I think 5.3 is fine, too. But please extend the test a bit. The current
one will pass even if the process segfaults. At least print something at
the end.
johannes