Re: Revisit: zend_call_method() - n number of arguments

On Sun, Oct 23, 2011 at 12:50 AM, Stas Malyshev <smalyshev@sugarcrm.com>wrote: > Hi! > > > On 10/22/11 2:36 AM, Nathan Nobbe wrote: > >> Hi, >> >> Another old issue I'd like to rehash with the upcoming release around the >> corner [1]. >> >> I patched 5.4 alpha2 for review [2]. >> > > I think better idea would be to add another API function > (zend_call_method_ex?), that implements arbitrary argument count (either via > array or via varargs) and make zend_call_method be a case of it, maybe. This > way you don't have to break existing API and also don't have to stop at 4. Hi Stas, That's what this patch does, there is a new function zend_call_method_multi, which takes an array, and I've revised zend_call method to use it. I could change it to varargs if that is preferred. thanks, -nathan