Re: BC break in 5.4, extending internal class
| From: | Pierre Joye | Date: | Mon, 24 Oct 2011 20:27:31 +0000 |
| Subject: | Re: BC break in 5.4, extending internal class | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-55938@lists.php.net to get a copy of this message | ||
hi,
On Mon, Oct 24, 2011 at 4:13 PM, Gustavo Lopes <glopes@nebm.ist.utl.pt> wrote:
> The change I did in 5.4 should be reverted and synced with 5.3 in the
> short term because it doesn't work reliably (even not considering the BC
> break) -- there are other methods for getting an invalid instance (the new
> reflection method and unserialize, at least).
Please do the revert, as you did the commit in the 1st place. As far
as I remember we have discussed this issue back then already as well.
> But even in 5.3, there are in SPL counter-measures that don't work
> reliably, like making a check in get_method.
Right, but that's another concern and the same cautiousness should be
taken there.
Thanks!
--
Pierre
@pierrejoye | http://blog.thepimp.net | http://www.libgd.org