[PATCH] sapi apache2 uninitialized content-length value
| From: | Doru Petrescu | Date: | Thu, 20 Nov 2003 11:13:15 +0000 |
| Subject: | [PATCH] sapi apache2 uninitialized content-length value | ||
| Groups: | php.internals | ||
| Request: | Send a blank email to internals+get-5612@lists.php.net to get a copy of this message | ||
Hi,
While playing with the upload progress meter I noticed that apache2
sapi implementation does not initialize the content-length sapi
variable. Apache 1.3 sapi does! and so does ALL OTHER interfaces. A
quick grep into the sources will reveal that only apache2handler and
apache2filter does not initialize this. Is there a reason for this ? Or
is just something that sliped ?
I wrote a patch to fix this. see attached. tested and it works with
no problem and correctly reports the content-length.
It is very simple and straight forward. copy/paste from apache 1.3
interface. now, I just wish nobody will upload anything over 2GB -
integer overflow will doom the upload.
--
Best regards,
Doru Petrescu
Senior Software Engineer
Astral Telecom Bucuresti
Attachment: [text/x-patch] patch.sapi_apache2_content_length.txt
Attachment: [text/x-patch] patch.sapi_apache2_content_length.txt