Re: datetime status
| From: | Derick Rethans | Date: | Mon, 21 Nov 2011 09:27:30 +0000 |
| Subject: | Re: datetime status | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-56454@lists.php.net to get a copy of this message | ||
On Mon, 21 Nov 2011, Stas Malyshev wrote:
> > That is incorrect, not every timezone DST change is 60 minutes.
>
> The I would guess this code in do_adjust_timezone() also wrong:
>
> case TIMELIB_ZONETYPE_ABBR: {
> timelib_sll tmp;
>
> tz->is_localtime = 1;
> tmp = tz->z;
> tmp -= tz->dst * 60;
> tmp *= 60;
> return tmp;
> }
>
> Since it makes the same assumption?
Maybe. It's not a huge problem and I think I might have shouted too
soon. Perhaps ABBR types are only triggered for a specific hard coded
list where the DST bit is always an hour. I'll need to check that!
(Added to my list).
Derick