Re: run-tests.php and dynamic extension dependencies

On Mon, 28 Nov 2011, Ferenc Kovacs wrote: > On Mon, Nov 28, 2011 at 2:11 PM, Derick Rethans <derick@php.net> wrote: > > > I'm currently writing a shared extension thta depends on another > > shared extension (igbinary). "make test" doesn't handle this at the > > moment, because it removes every extension= line from it's temporary > > php.ini. This means that the dependent extension (igbinary) now > > isn't loaded, which means my extension doesn't load either and > > obviously all the tests fail. > > > > I've attached a patch that adds a new --EXTENSIONS-- section to the > > PHPT format. The run-tests.php script makes sure that all extensions > > in that last are added to the PHP command with -dextension=... , but > > only if they're not build in (or already loaded in some other way). > > > > The patch is simple, and it doesn't touch any other section or > > functionality so I'm suggesting to commit it to PHP 5.3/5.4 and > > trunk some time soon. > > wouldn't --INI-- + extension do the same? No, as the run-tests.php framework changes "extension_dir" to "./modules/". It would also cause issues if you try to load an extension that is built-in. And it's not portable because not on every platform the extension name = extension.so cheers, Derick -- http://derickrethans.nl | http://xdebug.org Like Xdebug? Consider a donation: http://xdebug.org/donate.php twitter: @derickr and @xdebug