Re: session.cache_limiter empty string?
| From: | Yasuo Ohgaki | Date: | Tue, 29 Nov 2011 01:03:14 +0000 |
| Subject: | Re: session.cache_limiter empty string? | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-56667@lists.php.net to get a copy of this message | ||
2011/11/29 Yasuo Ohgaki <yohgaki@ohgaki.net>:
> Hi Karoly,
>
> 2011/10/12 Karoly Negyesi <karoly@negyesi.net>:
>> Setting session.cache_limiter to an empty string doesn't send headers.
>> Is this just an artefact of if (!strcasecmp(lim->name,
>> PS(cache_limiter))) not matching the empty string or does if
>> (PS(cache_limiter)[0] == '\0') return 0; deliberately stop it?
>>
>> Ie. what should I add to the documentation for people who don't want
>> PHP to send anything?
>
> If I remember correctly, old doc was referred as "none". Any invalid
> cache limiter name will be ignored, though.
>
> It may be good idea to raise notice error for invalid limiter name and
> introduce "none" limiter.
>
> Any comments?
>
Hi Karoly,
Failing silently in case of typo is not good.
Could you file feature request to bugs.php.net?
I'll make patch for trunk and commit it unless there is objection.
Regards,
--
Yasuo Ohgaki
yohgaki@ohgaki.net