Re: Using do_alloca() instead of emalloc()
| From: | Andi Gutmans | Date: | Sun, 23 Nov 2003 12:56:20 +0000 |
| Subject: | Re: Using do_alloca() instead of emalloc() | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-5678@lists.php.net to get a copy of this message | ||
Commited thanks.
Marcus, what we meant was that you shouldn't use do_alloca() in the engine except for in the cases I mentioned, and possibly cases where the allocations would be quite large. In the case of reflection API the allocations are small *and* the function returns right away, thus not keeping stuff on the stack for too long.
Andi
At 11:09 PM 11/20/2003 +0100, Timm Friebe wrote:
On Thu, 2003-11-20 at 10:48, Andi Gutmans wrote: Hey, I've been taking a look at the __autoload problem. During that time I saw that lots of places in the code (especially reflection API) use zend_str_tolower_dup(). [...] Here's a patch for zend_reflection_api.c which uses do_alloca / free_alloca in all relevant places. - Timm