RE: [PHP-DEV] Accessors v2 Patch

https://bugs.php.net/patch-display.php?bug_id=49526&patch=v2.1&revision=latest Alright, nevermind on the failing tests, figured that out. I didn't realize the test structure doesn't indicate that it was segfaulting, that fixed all of the failing tests. So... I guess this patch is up for discussion? I don't presently have any static getters implemented, as best I can tell it would require some changes to opcodes, I didn't dive into anything besides exploration there. -Clint -----Original Message----- From: Will Fitch [mailto:will.fitch@gmail.com] Sent: Sunday, December 11, 2011 1:41 PM To: Clint M Priest Cc: internals@lists.php.net Subject: Re: [PHP-DEV] Accessors v2 Patch Much better implementation. As for the failed tests, I would double check and make sure you don't have any stray debug statements (e.g. printf). Sent from my iPhone On Dec 11, 2011, at 2:27 PM, Clint M Priest <cpriest@zerocue.com> wrote: > > https://bugs.php.net/patch-display.php?bug_id=49526&patch=accessor_v2. > diff&revision=latest > > I rewrote part of how it handles the job due to abysmal performance of version 1. This one is > near the same performance as without the code changes using __get() and is actually faster in some > cases (public getter). > > I also checked all the tests and fixed the issues I found related. > > There is however some strange behavior that I do not understand. For some reason if I run all > of the tests, 100+ or so will fail. If I have the test script write those failed tests to a file > and just run those tests, all but four work fine. It appears to be something to do with line > endings, in other cases the output does not match expected because of the addition of > 'unicode' to the output. I've no idea what's going on here but after 3 days of > mucking around, I can't find a solution as to why this is occurring. > > These failures do not occur on a fresh checkout but nothing I've changed should be causing > any of the issues, just no idea here, any help would be appreciated. > > Felipe: I could not find any segmentation fault tests from before when you posted, nor now. > Are you still seeing segmentation faults? > > Thoughts? > > -Clint >