Re: Re: cvs: php-src /ext/gmp config.m4 gmp.c php_gmp.h
| From: | Jani Taskinen | Date: | Mon, 24 Nov 2003 16:10:35 +0000 |
| Subject: | Re: Re: cvs: php-src /ext/gmp config.m4 gmp.c php_gmp.h | ||
| References: | 1 2 3 4 5 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-5696@lists.php.net to get a copy of this message | ||
Fixed.
--Jani
On Mon, 24 Nov 2003, Joe Orton wrote:
>On Mon, Nov 24, 2003 at 05:47:09PM +0200, Jani Taskinen wrote:
>>
>> Actually, it propably is okay to just use __GMP_BITS_PER_MP_LIMB
>> and not include gmp-mparam.h at all?
>
>Ah, yes, that looks right: BITS_PER_MP_LIMB is only defined for arches
>where gmp has an assembler implementation; if gmp is built using the
>generic C code, gmp-mparam.h is empty.
>
>Index: ext/gmp/gmp.c
>===================================================================
>RCS file: /repository/php-src/ext/gmp/gmp.c,v
>retrieving revision 1.29.4.5
>diff -u -r1.29.4.5 gmp.c
>--- ext/gmp/gmp.c 19 Nov 2003 04:44:24 -0000 1.29.4.5
>+++ ext/gmp/gmp.c 24 Nov 2003 15:52:35 -0000
>@@ -1079,7 +1079,7 @@
>
> GMPG(rand_initialized) = 1;
> }
>- mpz_urandomb(*gmpnum_result, GMPG(rand_state), GMP_ABS (limiter) * BITS_PER_MP_LIMB);
>+ mpz_urandomb(*gmpnum_result, GMPG(rand_state), GMP_ABS (limiter) * __GMP_BITS_PER_MP_LIMB);
>
> ZEND_REGISTER_RESOURCE(return_value, gmpnum_result, le_gmp);
> }
>
>