Re: [Proposal] Remove the tail ws in codes
| From: | Pierre Joye | Date: | Sat, 24 Dec 2011 14:33:14 +0000 |
| Subject: | Re: [Proposal] Remove the tail ws in codes | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-57081@lists.php.net to get a copy of this message | ||
On Sat, Dec 24, 2011 at 12:56 PM, Derick Rethans <derick@php.net> wrote:
> On Sat, 24 Dec 2011, Pierre Joye wrote:
>
>> Laruence refers to the PHP C source code and removing trailing white
>> spaces is a good thing as it is part of our CS.
>>
>> Go ahead Laruence :)
>
> Please don't. Changing whitespace en-masse makes it a royal pain to do
> merges later. Please just fix them when you change the code on that line
> only.
There is no deal or pain to fix them in all branches at once. There is
no need either to do it all at once, but doing them while working on a
file in a separate commit before the actual change is just fine and is
a good practice.
--
Pierre
@pierrejoye | http://blog.thepimp.net | http://www.libgd.org