Re: Quick missing NEWS entry questions
| From: | Stas Malyshev | Date: | Mon, 02 Jan 2012 20:10:43 +0000 |
| Subject: | Re: Quick missing NEWS entry questions | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-57167@lists.php.net to get a copy of this message | ||
Hi!
My question is, should I go back and edit NEWS to put my change in? It would go under "PHP 5.4.0 Alpha 1"Generally, each substantial change should be in the NEWS under the version in which it appeared (for 5.4, all pre-release versions will be consolidated on release).
And if I do put it in, do I put it in both trunk and branches/PHP_5_4 ?No, only 5.4 as it's the first version it appeared in (in trunk, it's not NEWS anymore).
Also, everyone is using first names only in NEWS but Andrew is not unique in the file, should I use my full name, full, first name + initial?I'd advise the full name. First name only is usually used by people who are frequent committers so it is known who exactly that is. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227