[PATCH] Fix cal_from_jd() for Jewish calendar

From: Date: Fri, 13 Jan 2012 16:41:04 +0000
Subject: [PATCH] Fix cal_from_jd() for Jewish calendar
Groups: php.internals 
Request: Send a blank email to internals+get-57358@lists.php.net to get a copy of this message
This didn't seem to get much notice the first time I sent it, so as per the suggestion at (http://php.net/svn-php.php), I'm resending it. It would be great if someone could commit it to the source tree so this bug can be closed. Please let me know if I need to do something differently or if you have questions or objections. This is a patch to fix the main issue in bug #54254 (the other issue mentioned would require some structural changes in how calendars are handled and is more of a feature request), cal_from_jd(CAL_JEWISH) returns month=6 for Adar when there is only one Adar, (it should return 7, since if there is only one Adar it's AdarII). This will clear up an issue where cal_from_jd() returns a month that cal_days_in_month() reports to have 0 days due to an inconsistency in how dates are converted to and from the Jewish calendar. This patch should create the correct behavior. Thanks, Eitan https://bugs.php.net/bug.php?id=54254

Attachment: [text/x-patch] jewish_calendar_bug_54254.patch
« previous php.internals (#57358) next »