Re: Reflection to remove final
| From: | Pierre Joye | Date: | Tue, 17 Jan 2012 10:34:16 +0000 |
| Subject: | Re: Reflection to remove final | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-57385@lists.php.net to get a copy of this message | ||
hi Jan!
Patch looks good, but coding standard.
Please always use brackets, even for one line condition (if () foo else bar).
Cheers,
On Mon, Jan 16, 2012 at 7:06 PM, Jan Dolecek <juzna.cz@gmail.com> wrote:
> Hi,
>
> reflection is a great tool for testing, but it still misses support
> for mocking classes/methods marked as final. I created a small patch
> https://gist.github.com/1621839#file_php_finals.patch, examples
> how to
> use it https://gist.github.com/1621839#file_final_test.php and
> wrote a
> short article explaining it:
> http://blog.juzna.cz/2012/01/mock-vs-final-fights-in-testing/.
>
> Can you include it into svn pls?
> Thanks
>
> Jan Dolecek
> juzna.cz@gmail.com
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
--
Pierre
@pierrejoye | http://blog.thepimp.net | http://www.libgd.org