Re: Code freeze for 5.4

Hi!

We can make new session ID in PS_OPEN_FUNC() or PS_READ_FUNC() always when ID is not already initialized one, by calling private validation function from PS_OPEN_FUNC() or PS_READ_FUNC(). However, I think it's more cleaner to keep PS module's modular architecture. Current session module's code is complex enough. Not many people would understand the logic at a glance. New PS module writers should always write SID validation function. Separate API is easier for most people, I suppose.

I think calling one function wouldn't add that much and can be clearly commented if something is not clear enough from the code.

If it's ok to add structure members that requires current patch, I'll commit new module structure now. And I'll commit the rest for 5.4.1.

No, please don't commit anything in 5.4. I don't want any large changes now.

If you prefer to maintain current structure/API, I'll modify patch. I would like to add strict session to PHP 5.3, so I have to do that anyway for binary compatibility.

I'd propose to make a binary-compatible change for 5.3 and 5.4.1, and discuss what we do for trunk - I still like the idea of keeping less handlers better, and if that means we can have the same patch for all branches, then it's an added bonus. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227