Re: can I commit fix for Bug #60825?

On Mon, Jan 23, 2012 at 4:09 PM, Dmitry Stogov <dmitry@zend.com> wrote: > Hi Laruence, > > I'm not sure if the proposed patch fixes all the problems. > > Imagine that __FILE__ stored in some PHP variable and accessed after > include() has finished. That time C variable "tmp_inc_filename" won't be > valid but PHP variable may still refer to it. > Hi, I am not sure whether I got your point, but zend_std_cast_object_tostring will duplicate that "string", so zval_dtor tmp_inc_filename will okey(just efree that duplicate) I think. :) thanks > I didn't try to reproduce it, so I might be wrong. > > Thanks. Dmitry. > > > On 01/22/2012 06:42 AM, Laruence wrote: >> >> send again, >> >> dsp said he didn't received. >> >> thanks >> >> On Sun, Jan 22, 2012 at 1:19 AM, Laruence<laruence@php.net>  wrote: >>> >>> Hi: >>> >>>  I have fixed #60825 (Segfault when running symfony 2 tests) >>> >>>  cvs mail here: http://news.php.net/php.cvs/67503 >>> >>>  should I also commit this fix to 5.4 branch now? >>> >>> thanks >>> >>> -- >>> Laruence  Xinchen Hui >>> http://www.laruence.com/ >> >> >> >> > -- Laruence  Xinchen Hui http://www.laruence.com/