RE: [PHP-DEV] Uploading a patch fails...
| From: | Clint M Priest | Date: | Sun, 29 Jan 2012 01:54:36 +0000 |
| Subject: | RE: [PHP-DEV] Uploading a patch fails... | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-57556@lists.php.net to get a copy of this message | ||
Okay... Pierre had recommended I upload the patches to that bug report when I first got started. I
just finished getting the last of the hard stuff working tonight. The patch is pretty big (though
the 200k may have had a lot of white-space changes).
It may also be so big because that patch included updates to the Reflection extension as well as
tests for just about everything, plenty of code there.
Would it be best to break apart the code into sets of diffs, such as:
- Reflection
- Reflection Tests
- Feature
- Feature Tests
Thanks,
-Clint
-----Original Message-----
From: Ferenc Kovacs [mailto:tyra3l@gmail.com]
Sent: Saturday, January 28, 2012 4:00 PM
To: Stas Malyshev
Cc: Rasmus Lerdorf; Clint M Priest; internals@lists.php.net
Subject: Re: [PHP-DEV] Uploading a patch fails...
>
> BTW, I would recommend using Wiki and RFC for tracking new features,
> especially of this magnitude. This is obviously not a bug, and not a
> small feature request either...
the RFC is already in the wiki, AFAIR it is linked from the ticket also.
https://wiki.php.net/rfc/propertygetsetsyntax
https://wiki.php.net/rfc/propertygetsetsyntax-as-implemented
--
Ferenc Kovács
@Tyr43l - http://tyrael.hu