Re: zend_eval_stringl fixes, was: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/Zend/zend_execute_API.c trunk/Zend/zend_execute_API.c

On Tue, 7 Feb 2012, Stas Malyshev wrote: > > > I'm not sure this bug is critical enough to keep messing with the > > > code base this close to the release. Could you please describe > > > what is the current status, what was before the fix and what > > > exactly the problems are here? > > > > let me try to describe the whole thing. before any change. the > > OK, your fix looks ok, but seeing as we already had 2 patches there > and it's still not ok, and we want to get 5.4.0 out soonish, I think > we should do this: > > 1. Revert it (only these areas) to pre-319102 state (it'll have memory > leak but we lived with it so far) for 5.4.0. > > 2. Apply the proper fix to trunk now and 5.4.1 as soon as 5.4.0 out, > fixing both the leak and the return states and xdebug. > > Derick, does pre-319102 state of the code work for you? > Any objections to this from anybody? Works for me. But I'd like to test it after it's been reverted. Will there be one more RC? cheers, Derick -- http://derickrethans.nl | http://xdebug.org Like Xdebug? Consider a donation: http://xdebug.org/donate.php twitter: @derickr and @xdebug