Re: Let parse_str() parse more than max_input_vars args
| From: | Tjerk Anne Meesters | Date: | Thu, 15 Mar 2012 02:34:15 +0000 |
| Subject: | Re: Let parse_str() parse more than max_input_vars args | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-58948@lists.php.net to get a copy of this message | ||
On Thu, Mar 15, 2012 at 7:38 AM, Rasmus Lerdorf <rasmus@lerdorf.com> wrote:
>
> Yes, it would need a zend_alter_ini_entry_ex() call there. The patch
> wasn't complete, just a quick hack. But it would still have an
> out-of-context error message when you exceed it. At least with a
> userspace ini_set() the error would make sense.
>
As mentioned on IRC, a function signature of "array
parse_urlencoded(string $s)" would be useful too; the separated logic
would allow for avoiding max_input_vars altogether and not having to
worry about parameter name mangling (variable name rules). The nasty
part is that much of the treat_data code would have to be duplicated
(I think).
Besides that, applying the hash randomisation patch to only userland
arrays would make the max_input_vars less critical and at the same
time avoid breaking opcode caches and other low-level dependencies.