Re: com php-src: Fixed reference counting: ext/spl/spl_directory.c
| From: | David Soria Parra | Date: | Thu, 22 Mar 2012 11:22:15 +0000 |
| Subject: | Re: com php-src: Fixed reference counting: ext/spl/spl_directory.c | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-59122@lists.php.net to get a copy of this message | ||
On 2012-03-22, David Soria Parra <dsp@php.net> wrote:
> On 2012-03-22, Dmitry Stogov <dmitry@php.net> wrote:
>> Commit: 14af1fe6923c65a91cd77eab5a8d4326f854391d
>> Author: Dmitry Stogov <dmitry@zend.com> Thu, 22 Mar 2012 14:38:38 +0400
>> Parents: 523396cb28a0cb87ced9ec1179ef4f119d28ec80
>> Branches: PHP-5.3 PHP-5.4
>>
>
> why are you commiting the patch 3 times? we have a defined workflow
> how to patch in git.
FYI: I reverted the changes on PHP-5.4 and master branch and merged
the fix from the PHP-5.3 branch into PHP-5.4 and master. This
way we can only refer to this particular change as revision 14af1fe6
This will help us to follow the described workflow at
http://wiki.php.net/vcs/gitworkflow