Re: Fileinfo fixes for windows

hi Stas, On Wed, Apr 11, 2012 at 12:24 AM, Stas Malyshev <smalyshev@sugarcrm.com> wrote: > Hi! > >> However, as you won't merge the tests fixes either, we won't 5.4.1's >> tests at all to valid the build (way too many false positive), it does >> not really matter anymore. > > Wait, are we talking about new test fixes or about tests that are broken > in RC1 and need fixing? I was assuming it's the former but maybe I miss > the point entirely. I've run tests of RC1 on Linux and those were just > fine. If they fail somewhere else please tell me and I'll see if I > should add those. > I'm ok with pulling the LF fix, that seems innocent enough - it's not > even a code change, just a metadata change. btw, It is not a realy issue as we won't use 5.4.1 tests to test the release but 5.4's branch ones. Too many false positive. The lf should not be a problem either as the releases are packaged on linux, so LF is the default there. All in all, I do not see a critical stopping preventing us to go final (and begin with next soonish :) ). Cheers, -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org