Re: get_magic_quotes_gpc() returns false instead of 0

On Apr 24, 2012, at 9:43 AM, Stas Malyshev wrote: > Hi! > >> https://bugs.php.net/61784 >> >> The get_magic_quotes_gpc() function returns 0/1 before 5.4, but now >> it returns boolean false. Instead it should return 0. Fixing this >> feels like a bug fix, which would go in 5.4.1. Thoughts? > > I do not see a reason to hold 5.4.1 for this. The less people beginning to rely on this bug the better, and this is a critical time. The impact of this BC break feels larger considering MQ is enabled by default in PHP 5.3 and below. This change shouldn't damage the RC QA process as all this does (tm) is change the return of false to 0. And considering that the magic quotes feature is removed, this change should not affect other code. Oh, sometimes it's nice that more people use == versus ===. ;) Regards, Philip