Re: [RFC] Allow non-variable arguments to empty() and isset()

On Mon, Apr 30, 2012 at 3:50 PM, Patrick ALLAERT <patrickallaert@php.net> wrote: > Hi, > > 2012/4/12 Nikita Popov <nikita.ppv@googlemail.com>: >> PS: I added isset() too, to address the consistency concerns mentioned on IRC. > > I would have voted +1 if it didn't contain the isset() change. None of > the examples used in the isset_with_expr.phpt test seems logic to me. Hi: isset and empty are generally think as a pair, and the both even share one ZEND_OP: ZEND_ISSET_ISEMPTY_VAR so I think if you want to change empty, you should also change isset. thanks > > Care to explain the consistency concerns here? > > Patrick > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > -- Laruence  Xinchen Hui http://www.laruence.com/