Re: Old bug 40459: Stat and Dir stream wrapper methods do not call constructor
| From: | Johannes Schlüter | Date: | Fri, 18 May 2012 15:54:21 +0000 |
| Subject: | Re: Old bug 40459: Stat and Dir stream wrapper methods do not call constructor | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-60611@lists.php.net to get a copy of this message | ||
Hi,
On Fri, 2012-05-18 at 12:42 +0200, Jorrit Schippers - nCode wrote:
> So my question is: can anyone familiar with the Stream Wrapper code take
> a look at this issue? My C is not of sufficient level to fix this
> myself. My idea would be to abstract creating a stream wrapper instance
> and invoking the constructor to a separate function and calling that
> function from the various functions that use stream wrappers, as the
> amount of code needed to construct an instance and call the constructor
> seems quite high to copy everywhere.
"Fixing" this is quite trivial.. except that it breaks any code
depending on the current behavior where people are using the constructor
in a way which might have an bad impact. This could only be done in
master.
Sometime ago I stumbled over that behavior it and had an additional
issue preventing me from fixing it, which I don't remember right now ...
johannes