Re: full LFS support
| From: | Gustavo Lopes | Date: | Mon, 04 Jun 2012 07:50:57 +0000 |
| Subject: | Re: full LFS support | ||
| References: | 1 2 3 4 5 6 7 8 9 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-60734@lists.php.net to get a copy of this message | ||
On Mon, 4 Jun 2012 09:32:51 +0200, Pierre Joye wrote:
On Sun, Jun 3, 2012 at 1:55 PM, Gustavo Lopes <glopes@nebm.ist.utl.pt> wrote:I should tend to agree, but in any case it shouldn't stop us from fixing the streams C API to use the correct types. As a bonus, we'll have LFS support in compilers with 64-bit longs. -- Gustavo LopesThis most likely would be doable only in the next version as it requires changing the signatures of extension API functions. I suggest that you make a pull request *with some tests* (you can add a function to the debug build to create a large sparse file). I'll offer to review it then.There are other considerations to take care of besides adding simple LFS support (with limited needs out there). The magic with double and co is simply not clean and should be done with real 64bit or large integer support, or it will just be yet another ugly implementation in php.